Skip to content

Drop support for Python 3.6 - #192

Merged
phanak-sap merged 5 commits into
masterfrom
phanak-sap-drop-py36
Jan 12, 2022
Merged

phanak-sap merged 5 commits into
masterfrom
phanak-sap-drop-py36

Conversation

@phanak-sap

@phanak-sap phanak-sap commented Jan 11, 2022 •

Copy link
Copy Markdown
Contributor

Part of issue #190

Drop support for Python 3.6 and LXML versions, that work only in Python 3.6 9 (and not in any later version)

Part of issue #190
@codecov-commenter

codecov-commenter commented Jan 11, 2022 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.74%. Comparing base (bfa215f) to head (a1a0bfc).
⚠️ Report is 78 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files           6        6           
  Lines        2717     2717           
=======================================
  Hits         2520     2520           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Mark Python 3.7 as minimal supported version.
Python 3.6 support removal
Upgrade to minimal LXML package that still works on Python 3.7
- Upgrade to minimal LXML package that still works on Python 3.7
- Update pipy language classifiers
-
@phanak-sap phanak-sap changed the title Update .travis.yml Drop support for Python 3.6 and LXML versions, that work only in Python 3.6. Jan 11, 2022
@phanak-sap phanak-sap changed the title Drop support for Python 3.6 and LXML versions, that work only in Python 3.6. Drop support for Python 3.6 Jan 11, 2022
@phanak-sap
phanak-sap requested a review from filak-sap January 11, 2022 12:41
@phanak-sap

phanak-sap commented Jan 11, 2022 •

Copy link
Copy Markdown
Contributor Author

Should be Squashed to master.
BTW, see the - Coverage 92.74% 92.71% -0.04% for model.py? Which is not changed at all in this PR nor tests for it.

Not sure how the computation is done, but Codecov is still puzzling to me.

@phanak-sap
phanak-sap merged commit 674fab0 into master Jan 12, 2022
@phanak-sap
phanak-sap deleted the phanak-sap-drop-py36 branch January 12, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants